Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: keychain updates #412

Merged
merged 3 commits into from
Jan 25, 2025
Merged

feat: keychain updates #412

merged 3 commits into from
Jan 25, 2025

Conversation

golanglemonade
Copy link
Member

@golanglemonade golanglemonade commented Jan 25, 2025 •
edited
Loading

Removes the use of github.com/99designs/keyring

Confirmed on mac, it can save to keychain + retrieve on subsequent requests:

task cli:login                                                                                     
task: [cli:login:creds] go run main.go login -u [email protected]

Authentication Successful!
auth tokens successfully stored in keychain

(⎈ |default:default)➜  core git:(feat-keychain) go run cmd/cli/main.go group get
  ID                          NAME         DISPLAY NAME  DESCRIPTION                                         VISIBILITY  MANAGED  ORGANIZATION  MEMBERS  
  01JJFVMFKMR3M2JAAFRYFX3NZX  Viewers      Viewers       Openlane managed group containing all organization  PUBLIC      true     meowmeow      0

Depends on theopenlane/utils#51

@github-actions github-actions bot added enhancement New feature or request cli labels Jan 25, 2025
@golanglemonade
bump utils
f10049f 
Signed-off-by: Sarah Funkhouser <[email protected]>
@golanglemonade golanglemonade changed the title Feat keychain feat: keychain updates Jan 25, 2025
@golanglemonade golanglemonade marked this pull request as ready for review January 25, 2025 23:10
@golanglemonade golanglemonade requested a review from a team as a code owner January 25, 2025 23:10
@golanglemonade golanglemonade enabled auto-merge (squash) January 25, 2025 23:10
@golanglemonade golanglemonade merged commit 3b8a4a9 into main Jan 25, 2025
15 checks passed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@golanglemonade golanglemonade deleted the feat-keychain branch January 25, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matoszz matoszz matoszz approved these changes

@LemonAid711 LemonAid711 Awaiting requested review from LemonAid711 LemonAid711 is a code owner automatically assigned from theopenlane/blacksmiths

@theopenlane-bender theopenlane-bender Awaiting requested review from theopenlane-bender theopenlane-bender is a code owner automatically assigned from theopenlane/blacksmiths

Assignees
No one assigned
Labels
cli enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@golanglemonade @matoszz