Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button/theme.ts): add the missing dark modifier for Button bg color #1047

Merged
merged 1 commit into from
Oct 6, 2023
Merged

fix(button/theme.ts): add the missing dark modifier for Button bg color #1047

merged 1 commit into from
Oct 6, 2023

Conversation

JDouven
Copy link
Contributor

@JDouven JDouven commented Oct 6, 2023

@vercel
Copy link

vercel bot commented Oct 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 7:48am

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Attention: 486 lines in your changes are missing coverage. Please review.

Comparison is base (7461173) 99.54% compared to head (e17c09b) 93.66%.
Report is 108 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1047      +/-   ##
==========================================
- Coverage   99.54%   93.66%   -5.88%     
==========================================
  Files         163      187      +24     
  Lines        6621     8164    +1543     
  Branches      401      448      +47     
==========================================
+ Hits         6591     7647    +1056     
- Misses         30      517     +487     
Files Coverage Δ
src/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/components/Banner/index.ts 100.00% <100.00%> (ø)
src/components/Blockquote/Blockquote.tsx 100.00% <100.00%> (ø)
src/components/Blockquote/index.ts 100.00% <100.00%> (ø)
src/components/Blockquote/theme.ts 100.00% <100.00%> (ø)
src/components/Breadcrumb/theme.ts 100.00% <100.00%> (ø)
src/components/Button/Button.tsx 100.00% <100.00%> (ø)
src/components/Button/ButtonBase.tsx 100.00% <100.00%> (ø)
src/components/Button/theme.ts 100.00% <100.00%> (ø)
src/components/Card/Card.tsx 100.00% <100.00%> (ø)
... and 54 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rluders rluders merged commit 0050aef into themesberg:main Oct 6, 2023
maman pushed a commit to transkripid/flowbite-react that referenced this pull request Oct 7, 2023
…or (themesberg#1047)

fix(button/theme.ts): add the missing dark modifier for Button background colors

fix themesberg#1045

Co-authored-by: Joris Douven <[email protected]>
paghar pushed a commit to paghar/flowbite-react that referenced this pull request Oct 12, 2023
…or (themesberg#1047)

fix(button/theme.ts): add the missing dark modifier for Button background colors

fix themesberg#1045

Co-authored-by: Joris Douven <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button dark mode background colors are broken
3 participants