Fix/lint warning on button test file #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
paghar
force-pushed
the
fix/lint_warning_on_button_test_file
branch
from
3751df0 to
a343c40
Compare
|
@rluders I have changed the type to fix lint warning. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1036 +/- ##
==========================================
- Coverage 99.54% 93.91% -5.64%
==========================================
Files 163 202 +39
Lines 6621 8458 +1837
Branches 401 465 +64
==========================================
+ Hits 6591 7943 +1352
- Misses 30 515 +485
☔ View full report in Codecov by Sentry. |
|
@nigellima WDYT? |
nigellima
reviewed
Oct 3, 2023
paghar
force-pushed
the
fix/lint_warning_on_button_test_file
branch
from
a343c40 to
2179901
Compare
paghar
force-pushed
the
fix/lint_warning_on_button_test_file
branch
from
2179901 to
d35789f
Compare
paghar
force-pushed
the
fix/lint_warning_on_button_test_file
branch
from
d35789f to
4f6d249
Compare
paghar
force-pushed
the
fix/lint_warning_on_button_test_file
branch
from
4f6d249 to
7879568
Compare
|
@rluders should I close this PR? |
I actually missed this one, didn't have time to test it. Maybe @SutuSebastian could also give some feedback here. |
|
My only question is:
|
Yes, it seems to be for this reason. |
paghar
force-pushed
the
fix/lint_warning_on_button_test_file
branch
from
7879568 to
983d960
Compare
adding the null option to accept if the "as" property was null
paghar
force-pushed
the
fix/lint_warning_on_button_test_file
branch
from
983d960 to
1310c99
Compare
|
Then we're all good here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize the changes made and the motivation behind them.
Reference related issues using
#followed by the issue number.If there are breaking API changes - like adding or removing props, or changing the structure of the theme - describe them, and provide steps to update existing code.