This repository has been archived by the owner on Jun 29, 2023. It is now read-only.
Multi Token Pool #621
Merged
Multi Token Pool #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
client
jacque006
force-pushed
the
feature/multi-token-pool-party
branch
3 times, most recently
from
e272486 to
c673d7a
Compare
jacque006
commented
Jul 14, 2021
| @@ -80,10 +80,11 @@ async function main() { | |||
| `Registering ${numPubkeys} pubkeys. Custom mnemonic: ${!!pubkeyMnemonic}` | |||
| ); | |||
| const group = Group.new({ | |||
| n: pubkeyMnemonic, | |||
| n: parseInt(numPubkeys), | |||
There was a problem hiding this comment.
Pretty sure this derp was me, should work properly now.
jacque006
commented
Jul 14, 2021
| @@ -116,7 +116,7 @@ export async function handleNewBatch( | |||
| const receipt = await event.getTransactionReceipt(); | |||
| const logs = receipt.logs.map(log => rollup.interface.parseLog(log)); | |||
| const depositsFinalisedLog = logs.filter( | |||
| log => log.signature == "DepositsFinalised(uint256,bytes32,uint256)" | |||
| log => log.signature === "DepositsFinalised(uint256,bytes32,uint256)" | |||
There was a problem hiding this comment.
=== > == https://stackoverflow.com/a/3586781
jacque006
commented
Jul 14, 2021
| @@ -10,6 +10,8 @@ export interface Entry<Item> { | |||
| item: Item; | |||
| } | |||
|
|
|||
| // TODO Update this interface and implementations to | |||
| // use BigNumber for itemID. | |||
There was a problem hiding this comment.
Avoided this refactor as this PR is already large and didn't want to bork @kautukkundan 's work :) BigNumberish should be fine as well as long as the storage engine and tree both store in a large value format under the covers.
There was a problem hiding this comment.
oh makes sense, can discuss this
jacque006
commented
Jul 14, 2021
| @@ -176,7 +176,7 @@ export function parseG2(solG2: solG2): mclG2 { | |||
| } | |||
|
|
|||
| function dump(sol: solG1 | solG2): string { | |||
| return `0x${sol.map(n => n.toString().slice(2)).join()}`; | |||
| return `0x${sol.map(n => n.toString().slice(2)).join("")}`; | |||
There was a problem hiding this comment.
This is also my derp. join by default adds a comma separator which the previous implementation did not.
|
@kautukkundan @ChihChengLiang your 👀 would be especially appreciated on |
| // Setup and register custom tokens | ||
| const customTokens = await Promise.all([ | ||
| new CustomToken__factory(signer).deploy("Hubble", "HUB"), | ||
| new CustomToken__factory(signer).deploy("Telescope", "TLSC") |
| @@ -13,6 +14,22 @@ import { | |||
|
|
|||
| chai.use(chaiAsPromised); | |||
|
|
|||
| const txFactory = ( | |||
| @@ -10,6 +10,8 @@ export interface Entry<Item> { | |||
| item: Item; | |||
| } | |||
|
|
|||
| // TODO Update this interface and implementations to | |||
| // use BigNumber for itemID. | |||
There was a problem hiding this comment.
oh makes sense, can discuss this
jacque006
force-pushed
the
feature/multi-token-pool-party
branch
from
c673d7a to
5bc9dcb
Compare
SameTokenPool -> MultiTokenPool to support multiple token transactions. Convert numerous number types to BigNumber to reflect L1 values and prevent overflows. Add maxPendingTransactions to config file. ExampleToken -> CustomToken test contract to aid in testing multiple ERC20 tokens. Fix deploy script not generating the correct number of public keys. Update client integration test and utilities to support multiple tokens. Fix bug in mcl.dump where comma was being added to joined hexes.
jacque006
force-pushed
the
feature/multi-token-pool-party
branch
from
5bc9dcb to
0893844
Compare
This was referenced Jul 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #626
TODO
MultiTokenPoolAdd script to generate and deposit (create state) for fee receiversScripts to add 4 tokens and fee receivers for dev case #476number->BigNumberrefactor points.