Disallow calling processWithdrawCommitment twice

thehubbleproject · Jan 4, 2022 · c22ce25 · c22ce25
1 parent cb793dd
commit c22ce25
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/contracts/WithdrawManager.sol b/contracts/WithdrawManager.sol
@@ -41,6 +41,10 @@ contract WithdrawManager {
         uint256 batchID,
         Types.MMCommitmentInclusionProof memory commitmentMP
     ) public {
+        require(
+            processed[commitmentMP.commitment.body.withdrawRoot] == "",
+            "WithdrawManager: commitment was already processed"
+        );
         vault.requestApproval(batchID, commitmentMP);
         (address addr, uint256 l2Unit) =
             tokenRegistry.safeGetRecord(commitmentMP.commitment.body.tokenID);

diff --git a/test/slow/rollup.massMigration.test.ts b/test/slow/rollup.massMigration.test.ts
@@ -208,6 +208,12 @@ describe("Mass Migrations", async function() {
             "Transaction cost: Process Withdraw Commitment",
             receiptProcess.gasUsed.toNumber()
         );
+
+        await expectRevert(
+            withdrawManager.processWithdrawCommitment(batchId, batch.proof(0)),
+            "WithdrawManager: commitment was already processed"
+        );
+
         const withdrawProof = migrationTree.getWithdrawProof(0);
         const [, claimer] = await ethers.getSigners();
         const claimerAddress = await claimer.getAddress();