Fixes #38134 - Add custom pagination to table #10413
Open
+39
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmalyjur
force-pushed
the
custom_table_pagination
branch
from
c7d109f to
f5310b0
Compare
girijaasoni
reviewed
Jan 15, 2025
| defaultParams.per_page = urlPerPage; | ||
| } | ||
| } | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps |
There was a problem hiding this comment.
@girijaasoni It's not, but it's nicer to have this eslint-disable comment than to see the "useEffect has missing dependencies" warning, in my opinion. However, I know we should be consistent. What do you think?
kmalyjur
force-pushed
the
custom_table_pagination
branch
from
f5310b0 to
bf2faf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds custom pagination to the TableIndexPage component and prevents users from navigating to a non-existent page by modifying the URL.
Needed for Fixes #38090 - Add filtering to job invocation hosts table.