New Tree Species: Golden Elm #194
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes:
Added the Golden Elm, the first new tree to be added since maybe Forestry 1.7? This has been a fun little experiment for me and will help pave the way for more trees to be added in future (mainly because now I know what files have to be added to accomplish it.)
The Golden Elm is accurate in terms of its species information as far as this website is concerned. Might not be the best source of information but it's good enough for me.
The Hill Cherry was corrected to be part of the Rosales order and Prunus genus, which also makes it related to the elm, somewhat. Initially this was also done as the Hill Cherry was to be used to breed it, but that has since been changed to the Cherry Blossom instead.
Other changes:
All arboriculture.registerSpecies() calls were updated to use TextColor instead of Color, to fix a depreciation warning.
Also added a method to generate an ellipsoid/spheroid of blocks in the FeatureHelper class. Maybe not the cleanest method but it gets the job done and doesn't seem to be adverse for performance in terms of how it's implemented.