Feat/wizard #8
Merged
Feat/wizard #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robmorgan-tab
force-pushed
the
feat/wizard
branch
from
a6ef998 to
131472c
Compare
src/wizard.test.ts
Outdated
| describe('getEntryPointPrompt', () => { | ||
| describe('initial value', () => { | ||
| it('matches the given document syntax', () => { | ||
| const randomString = Math.random().toString(36).substring(2) |
There was a problem hiding this comment.
I'd suggest that we refactor this generator chain to its own utility function, as it's used in a few places.
There was a problem hiding this comment.
moved out to test-utils and added tests for them
src/wizard.ts
Outdated
| } | ||
|
|
||
| export const init = async (): Promise<void> => { | ||
| const processDirectory = process.env.INIT_CWD?.split('/').reverse()[0] || '' |
There was a problem hiding this comment.
Something to consider is that I think INIT_CWD isn't available by default on Windows systems, which is why it's an optional type.
There was a problem hiding this comment.
This is now the much neater const processDirectory = path.parse(process.env.INIT_CWD || '').base
Merged
robmorgan-tab
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: #1
Screen.Recording.2022-11-22.at.15.10.54.mov