Implement jwt in session #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Cynnexis
commented
Jun 2, 2019
Cynnexis
commented
- JWT's are linked to the session.
- The JWT expired after 1h.
- When accessing a sensible page when the JWT is not verified or expired, the website signs out the user and redirect them to the index page.
* Added `JWTManager.Builder` to help create JWT easily. (tested) * Tried to add the JWT to the client session.
* Used the builder to create a JWT.
* The JWT is now checked during the reservation. If it has expired, the user can now longer access the `Reservation` page.
* Branch is over. The JWT mechanism works perfectly fine. * The JWT expired after 1h. * When accessing a sensible page when the JWT is not verified or expired, the website sign out the user and redirect them to the index page. * Fixed `JWTManager::verify()` method. * Fixed `error.jsp` that had a variable translation problem.
* Added `JWTManager.Builder` to help create JWT easily. (tested) * Tried to add the JWT to the client session.
* Used the builder to create a JWT.
* The JWT is now checked during the reservation. If it has expired, the user can now longer access the `Reservation` page.
* Branch is over. The JWT mechanism works perfectly fine. * The JWT expired after 1h. * When accessing a sensible page when the JWT is not verified or expired, the website sign out the user and redirect them to the index page. * Fixed `JWTManager::verify()` method. * Fixed `error.jsp` that had a variable translation problem.
…imate-web-group/ChampixExpress into implement-jwt-in-session
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.