Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared root but nested #77

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Shared root but nested #77

merged 3 commits into from
Oct 31, 2024

Conversation

ardatan
Copy link
Member

@ardatan ardatan commented Oct 31, 2024

Taken from ardatan/graphql-tools#6620

In case of a shared root field, the gateway should extract available selection set (nestedly) for each subgraph correctly, then merge deeply the results.

Blocked by graphql-hive/console#5856

Copy link

github-actions bot commented Oct 31, 2024

Compatibility Results

Summary

Gateway Compatibility Test Cases Test Suites
Hive Gateway 100.00% 🟢 171 🟢 41
Apollo Router 97.66% 🟢 167 ❌ 4 🟢 39 ❌ 2
Apollo Gateway 97.08% 🟢 166 ❌ 5 🟢 38 ❌ 3
Cosmo Router 72.51% 🟢 124 ❌ 47 🟢 19 ❌ 22
Grafbase Gateway 59.06% 🟢 101 ❌ 70 🟢 19 ❌ 22

Detailed Results

Take a closer look at the results for each gateway.

You can look at the full list of tests here. Every test id corresponds to a directory in the src/test-suites folder.

Hive Gateway

Results abstract-types
🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢
child-type-mismatch
🟢🟢🟢🟢
circular-reference-interface
🟢🟢
complex-entity-call
🟢
corrupted-supergraph-node-id
🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢
enum-intersection
🟢🟢🟢🟢🟢
fed1-external-extends
🟢🟢
fed1-external-extends-resolvable
🟢
fed1-external-extension
🟢🟢
fed2-external-extends
🟢🟢
fed2-external-extension
🟢🟢
include-skip
🟢🟢🟢🟢
input-object-intersection
🟢🟢🟢
interface-object-with-requires
🟢🟢🟢🟢🟢🟢🟢
keys-mashup
🟢
mutations
🟢🟢🟢
mysterious-external
🟢🟢
nested-provides
🟢🟢
node
🟢
non-resolvable-interface-object
🟢🟢🟢🟢🟢🟢🟢
null-keys
🟢
override-type-interface
🟢🟢🟢🟢
override-with-requires
🟢🟢🟢🟢
parent-entity-call
🟢
parent-entity-call-complex
🟢
provides-on-interface
🟢🟢
provides-on-union
🟢🟢
requires-interface
🟢🟢🟢🟢🟢
requires-requires
🟢🟢🟢🟢🟢
requires-with-argument
🟢🟢🟢🟢🟢
requires-with-fragments
🟢🟢🟢🟢🟢🟢
shared-root
🟢🟢
simple-entity-call
🟢
simple-inaccessible
🟢🟢🟢🟢
simple-interface-object
🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢
simple-override
🟢🟢
simple-requires-provides
🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢
typename
🟢🟢🟢🟢🟢🟢
unavailable-override
🟢🟢
union-interface-distributed
🟢🟢🟢🟢🟢🟢🟢
union-intersection
🟢🟢🟢🟢🟢🟢🟢🟢

Apollo Router

Results abstract-types
🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢
child-type-mismatch
🟢🟢🟢🟢
circular-reference-interface
🟢🟢
complex-entity-call
🟢
corrupted-supergraph-node-id
🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢
enum-intersection
🟢🟢🟢🟢🟢
fed1-external-extends
🟢🟢
fed1-external-extends-resolvable
🟢
fed1-external-extension
🟢🟢
fed2-external-extends
🟢🟢
fed2-external-extension
🟢🟢
include-skip
🟢🟢🟢🟢
input-object-intersection
🟢🟢🟢
interface-object-with-requires
🟢🟢🟢🟢🟢🟢🟢
keys-mashup
mutations
🟢🟢🟢
mysterious-external
🟢🟢
nested-provides
🟢🟢
node
🟢
non-resolvable-interface-object
🟢🟢🟢🟢🟢🟢🟢
null-keys
🟢
override-type-interface
🟢🟢🟢🟢
override-with-requires
🟢🟢🟢🟢
parent-entity-call
🟢
parent-entity-call-complex
🟢
provides-on-interface
🟢🟢
provides-on-union
🟢🟢
requires-interface
🟢🟢🟢🟢🟢
requires-requires
🟢🟢🟢🟢🟢
requires-with-argument
🟢🟢❌❌❌
requires-with-fragments
🟢🟢🟢🟢🟢🟢
shared-root
🟢🟢
simple-entity-call
🟢
simple-inaccessible
🟢🟢🟢🟢
simple-interface-object
🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢
simple-override
🟢🟢
simple-requires-provides
🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢
typename
🟢🟢🟢🟢🟢🟢
unavailable-override
🟢🟢
union-interface-distributed
🟢🟢🟢🟢🟢🟢🟢
union-intersection
🟢🟢🟢🟢🟢🟢🟢🟢

Apollo Gateway

Results abstract-types
🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢
child-type-mismatch
🟢🟢🟢🟢
circular-reference-interface
🟢🟢
complex-entity-call
🟢
corrupted-supergraph-node-id
🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢
enum-intersection
🟢🟢🟢🟢🟢
fed1-external-extends
🟢🟢
fed1-external-extends-resolvable
🟢
fed1-external-extension
🟢🟢
fed2-external-extends
🟢🟢
fed2-external-extension
🟢🟢
include-skip
🟢🟢🟢🟢
input-object-intersection
🟢🟢🟢
interface-object-with-requires
🟢🟢🟢🟢🟢🟢🟢
keys-mashup
mutations
🟢🟢🟢
mysterious-external
🟢🟢
nested-provides
🟢🟢
node
🟢
non-resolvable-interface-object
🟢❌🟢🟢🟢🟢🟢
null-keys
🟢
override-type-interface
🟢🟢🟢🟢
override-with-requires
🟢🟢🟢🟢
parent-entity-call
🟢
parent-entity-call-complex
🟢
provides-on-interface
🟢🟢
provides-on-union
🟢🟢
requires-interface
🟢🟢🟢🟢🟢
requires-requires
🟢🟢🟢🟢🟢
requires-with-argument
🟢🟢❌❌❌
requires-with-fragments
🟢🟢🟢🟢🟢🟢
shared-root
🟢🟢
simple-entity-call
🟢
simple-inaccessible
🟢🟢🟢🟢
simple-interface-object
🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢
simple-override
🟢🟢
simple-requires-provides
🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢
typename
🟢🟢🟢🟢🟢🟢
unavailable-override
🟢🟢
union-interface-distributed
🟢🟢🟢🟢🟢🟢🟢
union-intersection
🟢🟢🟢🟢🟢🟢🟢🟢

Cosmo Router

Results abstract-types
🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢
child-type-mismatch
❌❌❌🟢
circular-reference-interface
🟢🟢
complex-entity-call
corrupted-supergraph-node-id
❌🟢🟢🟢🟢❌🟢🟢🟢🟢
enum-intersection
🟢🟢❌🟢🟢
fed1-external-extends
🟢🟢
fed1-external-extends-resolvable
fed1-external-extension
🟢🟢
fed2-external-extends
🟢🟢
fed2-external-extension
🟢🟢
include-skip
🟢🟢🟢🟢
input-object-intersection
🟢🟢🟢
interface-object-with-requires
❌❌🟢🟢❌❌❌
keys-mashup
🟢
mutations
🟢🟢❌
mysterious-external
🟢🟢
nested-provides
🟢🟢
node
🟢
non-resolvable-interface-object
🟢🟢🟢🟢❌🟢❌
null-keys
override-type-interface
🟢❌🟢🟢
override-with-requires
🟢🟢🟢🟢
parent-entity-call
🟢
parent-entity-call-complex
provides-on-interface
❌❌
provides-on-union
❌❌
requires-interface
🟢🟢❌🟢🟢
requires-requires
🟢🟢🟢🟢🟢
requires-with-argument
❌❌❌❌❌
requires-with-fragments
❌❌❌❌❌❌
shared-root
🟢❌
simple-entity-call
🟢
simple-inaccessible
🟢🟢🟢❌
simple-interface-object
🟢🟢🟢🟢🟢🟢🟢❌❌🟢❌❌❌
simple-override
🟢🟢
simple-requires-provides
🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢
typename
🟢🟢🟢🟢❌🟢
unavailable-override
🟢🟢
union-interface-distributed
❌🟢🟢🟢🟢🟢🟢
union-intersection
🟢🟢🟢❌❌🟢🟢❌

Grafbase Gateway

Results abstract-types
🟢🟢🟢🟢❌🟢🟢🟢❌🟢❌❌🟢🟢❌❌❌
child-type-mismatch
❌❌❌🟢
circular-reference-interface
🟢🟢
complex-entity-call
corrupted-supergraph-node-id
❌🟢❌🟢🟢❌🟢🟢🟢🟢
enum-intersection
🟢🟢🟢🟢🟢
fed1-external-extends
🟢🟢
fed1-external-extends-resolvable
fed1-external-extension
🟢🟢
fed2-external-extends
🟢🟢
fed2-external-extension
🟢🟢
include-skip
❌❌❌❌
input-object-intersection
🟢🟢🟢
interface-object-with-requires
🟢🟢❌🟢❌❌❌
keys-mashup
🟢
mutations
🟢🟢🟢
mysterious-external
🟢🟢
nested-provides
🟢🟢
node
🟢
non-resolvable-interface-object
❌🟢❌🟢🟢🟢❌
null-keys
override-type-interface
❌❌🟢🟢
override-with-requires
🟢❌❌❌
parent-entity-call
parent-entity-call-complex
provides-on-interface
❌❌
provides-on-union
🟢🟢
requires-interface
❌🟢❌🟢🟢
requires-requires
❌❌❌❌❌
requires-with-argument
🟢❌❌❌❌
requires-with-fragments
❌❌❌❌❌🟢
shared-root
❌❌
simple-entity-call
🟢
simple-inaccessible
🟢🟢🟢🟢
simple-interface-object
🟢🟢❌🟢❌❌❌🟢❌❌❌❌❌
simple-override
🟢🟢
simple-requires-provides
🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢❌❌
typename
🟢🟢🟢🟢🟢🟢
unavailable-override
🟢🟢
union-interface-distributed
🟢🟢🟢🟢🟢🟢🟢
union-intersection
❌🟢❌❌🟢🟢❌❌

@kamilkisiela kamilkisiela enabled auto-merge (squash) October 31, 2024 10:44
@kamilkisiela kamilkisiela merged commit 246d86a into main Oct 31, 2024
3 checks passed
@kamilkisiela kamilkisiela deleted the shared-root-nested branch October 31, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants