Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run deploy script instead of builtin pnpm deploy #2027

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Conversation

hasparus
Copy link
Collaborator

I don't know if OG Image service should be deployed, but it kinda annoyed me to have a red CI all the time, because I was afraid I broke it.

It's breaking now because pnpm deploy requires an argument (a directory).

https://pnpm.io/cli/deploy

Instead, we wanna call pnpm run with an argument deploy (a name of our script).

This "run" was refactored out about 2 months ago.

Copy link

changeset-bot bot commented Jan 31, 2025

⚠️ No Changeset found

Latest commit: 4ad0fb5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@theguild/components 9.3.0-alpha-20250131190158-4ad0fb5b0165a8c55a75033b5a040d183b9faa6e npm ↗︎ unpkg ↗︎

@hasparus hasparus merged commit 8e5e57a into main Feb 3, 2025
5 checks passed
@hasparus hasparus deleted the pnpm-run-deploy branch February 3, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants