[ET-2293] Alias Moment for react-day-picket #2379
Open
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redscar
changed the title
redscar
added
code review
dpanta94
requested changes
Feb 7, 2025
| @@ -54,3 +54,4 @@ | |||
| /vendor/woocommerce/action-scheduler/**/*.php | |||
| /node_modules/php-date-formatter/js/php-date-formatter.js | |||
| /node_modules/php-date-formatter/js/php-date-formatter.min.js | |||
| /node_modules/moment/dist/*.js | |||
There was a problem hiding this comment.
Until the bug on pup is fixed, this will probably need to go into the .distfiles of parent plugins as well. ET and TEC.
redscar
added
hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting a Hold on PR in favor of
🎫 Ticket
ET-2293
🗒️ Description
This issue mainly occurred on versions of WordPress lower than 7.2. When you would edit an event on the block editor that contained the ticket block using ET 5.18, and then update ET to 5.19 and edit the same event, the block would throw an error.
Upon inspection this was due to webpack not being able to find
./node_modules/react-day-picker/moment/index.js.The issue is that we recently updated
react-day-pickerto version 9, in which it dropped support for Moment. So that file was not there.The fix I implemented mapped the actual Moment package to the
react-day-picker/momentdirectory.🎥 Artifacts
Screencast.from.02-06-2025.11.31.40.AM.webm
✔️ Checklist
npm run changelogto add changelog file(s). More info herewpunitorintegrationtests.wpunitorintegrationtests.