TCMN-177 Correction to docblocks for where and all methods
#2341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdokus
added
question
sdokus
removed
the
question
|
Check the PHPStan on GHA, it seems like 512 is not enough memory. |
rafsuntaskin
requested changes
Jan 24, 2025
Whoops just seeing this, but I think that is an expected issue but Dimi is planning on addressing it later |
bordoni
approved these changes
Jan 25, 2025
rafsuntaskin
approved these changes
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
TCMN-177
🗒️ Description
A user reported that they were seeing errors in PHPStan when trying to use the ORM and in reviewing our doc blocks for some methods, it seems like some updates are needed to more accurately reflect what is returned (
all) or how many arguments are accepted (where).🎥 Artifacts
After changes:
✔️ Checklist
npm run changelogto add changelog file(s). More info herewpunitorintegrationtests.wpunitorintegrationtests.