React 18 compatibility #2268
Merged
React 18 compatibility #2268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the libraries used by the modules today are shipping with WP, no need to rebundle them.
This is not a solution since no replacement is provided. The todo note is a reminder to come back to this.
…alendar/tribe-common into fix/TEC-5322-wp-67-packages
The php-date-formatter package does not really export anything, so it cannot be aliased in webpack externals. The next best thing is moving the script to Common and providing a handle for it.
While we need the plugin text domain in the matching function, no need to load markup and translate information.
lucatume
force-pushed
the
fix/TEC-5322-wp-67-packages
branch
from
406b23c to
01ab890
Compare
…alendar/tribe-common into fix/TEC-5322-wp-67-packages
lucatume
force-pushed
the
fix/TEC-5322-wp-67-packages
branch
from
a4d4a23 to
b21c56a
Compare
lucatume
force-pushed
the
fix/TEC-5322-wp-67-packages
branch
from
cc8883c to
b29019c
Compare
This updates the `data` attribute to use a less generic name and modifies the `click` handler logic to target IAN elements only. Additionally, ensure elements exist in the current context before targeting them.
lucatume
force-pushed
the
fix/TEC-5322-wp-67-packages
branch
from
89547e7 to
6fd025a
Compare
lucatume
force-pushed
the
fix/TEC-5322-wp-67-packages
branch
from
6fd025a to
1142ac7
Compare
…alendar/tribe-common into fix/TEC-5322-wp-67-packages
dpanta94
requested changes
Jan 24, 2025
Comment on lines
+53
to
+54
| "node_modules/php-date-formatter/js/php-date-formatter.js", | ||
| "node_modules/php-date-formatter/js/php-date-formatter.min.js", |
There was a problem hiding this comment.
Can we include those outside of node_modules ?
There was a problem hiding this comment.
I think the build system should support this, changing the way dependencies are managed, in node_modules and through npm, to go with something that is fixed (in vendor or includes) seems working around a bug.
The node_modules directory is being included when ET is built.
Furthermore, this is both included directly, and imported in the blocks.
Could the build system be fixed?
| @@ -258,6 +258,7 @@ public function load_assets() { | |||
| [ 'tribe-attrchange', 'vendor/attrchange/js/attrchange.js' ], | |||
| [ 'tec-ky-module', 'vendor/ky/ky.js', [], null, [ 'module' => true ] ], | |||
| [ 'tec-ky', 'vendor/ky/tec-ky.js', [ 'tec-ky-module' ], null, [ 'module' => true ] ], | |||
| [ 'tec-common-php-date-formatter', 'node_modules/php-date-formatter/js/php-date-formatter.js' ], | |||
There was a problem hiding this comment.
the file source would need to be replaced here as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: TEC-5322
Update asset version, registration and usage to align with React 18.