Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature > Attendees page #2066

Merged
merged 6 commits into from
Apr 9, 2024
Merged

Feature > Attendees page #2066

merged 6 commits into from
Apr 9, 2024

Conversation

juanfra
Copy link
Contributor

@juanfra juanfra commented Apr 3, 2024 •
edited
Loading

🎫 Ticket

ET-1707

🗒️ Description

  • Adding the position parameter for the subpages, so we can set the order.

🎥 Artifacts

Screen.Recording.2024-03-21.at.16.30.46.mov

✔️ Checklist

  • Changelog entry in the readme.txt file.
  • Code is covered by NEW wpunit or integration tests.
  • Code is covered by EXISTING wpunit or integration tests.
  • Are all the required tests passing?
  • Automated code review comments are addressed.
  • Have you added Artifacts?
  • Check the base branch for your PR.
  • Add your PR to the project board for the release.

@juanfra juanfra self-assigned this Apr 3, 2024
@juanfra juanfra added code review Status: requires a code review. needs release Needs an associated release in Central before merging. needs changelog Needs a changelog entry before merging. labels Apr 3, 2024
codingmusician
codingmusician previously approved these changes Apr 8, 2024
View reviewed changes
@rafsuntaskin rafsuntaskin changed the base branch from master to release/G24.corgi April 8, 2024 21:54
@rafsuntaskin rafsuntaskin dismissed codingmusician’s stale review April 8, 2024 21:54

The base branch was changed.

@rafsuntaskin rafsuntaskin removed code review Status: requires a code review. needs release Needs an associated release in Central before merging. labels Apr 8, 2024
@juanfra juanfra changed the title [draft] Feature > Attendees page Feature > Attendees page Apr 9, 2024
@juanfra juanfra requested a review from redscar April 9, 2024 15:15
@juanfra juanfra merged commit e19cc2d into release/G24.corgi Apr 9, 2024
11 of 12 checks passed
@juanfra juanfra deleted the feature/attendees-page branch April 9, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codingmusician codingmusician codingmusician approved these changes

@rafsuntaskin rafsuntaskin Awaiting requested review from rafsuntaskin

@redscar redscar Awaiting requested review from redscar

Assignees

@juanfra juanfra

Labels
needs changelog Needs a changelog entry before merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@juanfra @codingmusician @redscar @rafsuntaskin