Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17. implement toast notifications on all messages not requiring user input #49

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

NickRoccodev11
Copy link
Collaborator

@NickRoccodev11 NickRoccodev11 commented Oct 4, 2024

Description

This code changes all messages that do not require user input to toast notifications via the react-toastify library. This includes:

  • alert messages
  • messages handled as state and rendered as elements (like <p> or <span> tags )

In addition, the listName input now clears after submission of a new list name, and padding was added to the bottom of the "share list" div temporarily to make it visible for testing.

Related Issue

closes #48

Acceptance Criteria

-All messages that do not require a user response should now appear as toast notifications
-The listName state and associated input should be cleared after submitting a list name

Type of Changes

refactoring
bug fix

Updates

After

toastnotifications

Testing Steps / QA Criteria

  • after pulling, you must install react-toastify: npm install --save react-toastify
  • perform any/all actions that trigger a message that does not require user response, such as:
  1. success/ failure creating a list
  2. success/ failure purchasing an item
  3. success/ failure/ warning when trying to add an item to the list (try entering an empty list)
  4. success/ failure sharing list with others

Copy link

github-actions bot commented Oct 4, 2024

Visit the preview URL for this PR (updated for commit 528294f):

https://tcl-74-smart-shopping-list--pr49-nr-toastnotification-17hzy50a.web.app

(expires Fri, 11 Oct 2024 19:19:29 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 79d73546692f99aad8468c28e36db434e2c190ac

@NickRoccodev11 NickRoccodev11 marked this pull request as ready for review October 4, 2024 19:21
@dterceroparker
Copy link
Member

I tested it and it looks great! Wohoo! Great work!

Copy link
Collaborator

@shuveksha-tuladhar shuveksha-tuladhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!!

@NickRoccodev11 NickRoccodev11 merged commit bf044ad into main Oct 5, 2024
3 checks passed
@NickRoccodev11 NickRoccodev11 deleted the nr-toastnotifications branch October 5, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

17. Convert all messages to toast notifications
3 participants