-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #14.2 Implement Disclosure component with collapsible content #37
Conversation
…d accessibility features.
… and collapsible content. Added aria attributes, keyboard interaction, and dynamic icons for expanded/collapsed states.
Visit the preview URL for this PR (updated for commit ce80ef6): https://tcl-74-smart-shopping-list--pr37-sd-st-14-2-muq6qvkn.web.app (expires Sat, 05 Oct 2024 13:14:19 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 79d73546692f99aad8468c28e36db434e2c190ac |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow! Impressive! You both went above and beyond by even adding icons.
We all know that dark and light mode colors can vary based on computer setups, but I was able to test by highlighting the content (hopefully I didn't miss anything!).
Since we removed the tabular format, my only feedback would be to consider updating the clickable boxes for purchasing, as they don't currently convey the action of purchasing. These could be replaced with purchase icons in a future issue.
Overall, I'm truly impressed!
Thank you @dterceroparker . We will work towards implementing light and dark modes once we decide on the CSS framework to use. In the meantime, I have fixed the background color. Additionally, a new issue (#38 ) has been created for the dynamic purchasing icon feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fantastic. very impressive!
Description
This PR introduces a disclosure component that allows users to expand and collapse content sections. The key features include:
aria-expanded
to reflect the current state andaria-controls
to link to the content element.id
attributes for accessible linking between the trigger and content.It also incorporates several enhancements aimed at improving the user interface and overall experience of the list feature:
Share
icon has been added to eachList
, which currently navigates to the Manage List pageDelete
button has been replaced by of a delete icon on each item.Create a list
input has been repositioned to the top of the page for improved visibility and accessibility.Related Issue
<Disclosure>
component #33Acceptance Criteria
Conceptually, a disclosure is comprised of two parts: a trigger, which users interact with to control the state of the component, and content, which contains the content that is expanded and collapsed by the trigger.
Trigger requirements
Content requirements
Type of Changes
enhancement
Updates
Before
After
Testing Steps / QA Criteria