Added Match Breakdown for the 2024 game, Crescendo #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based layout on the site version of the Match Breakdown Based functionlity on previous year's standards
|
This is awesome! Thank you so much! Let me give this a look soon. As a heads up - we're blocked right now on shipping updates to the App Store due to Apple's guidelines around needing to support Sign In with Apple. We've done the prerequisite work on the server to support this, but haven't gotten the sign in integrated into iOS yet. I'll have to take another stab at this, since #880 seems out of date 😅 |
|
Awesome thanks! I would offer to provide help but that looks way over my head. |
|
Dropped a new commit here to back out a few unrelated changes. Tests aren't passing on main right now so - going to manually merge. Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added Match Breakdown for the 2024 game, Crescendo
Based layout on the site version of the Match Breakdown
Based functionality on previous year's standards
Motivation and Context
There is no breakdown for 2024 yet, so I wanted to get that going before the season is over.
Will probably work on 2023 next since it's also missing :)
How Has This Been Tested?
Since this was only a change on the match breakdown page, I tested this against the full site on many different matches to make sure the information was correct.
I also added a couple more rows of data that aren't on the site (and let @dracco1993 know about these) that provide more data to uses about the extra RPs:
Screenshots