Thanos Receive design #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipgough
commented
Jun 10, 2024
| // ObjectStorageConfig is the secret's key that contains the object storage configuration. | ||
| // The secret needs to be in the same namespace as the ReceiveHashring object. | ||
| // +kubebuilder:validation:Required | ||
| ObjectStorageConfig corev1.SecretKeySelector `json:"objectStorageConfig"` |
There was a problem hiding this comment.
@saswatamcode should we be able to specify this globally and just allow overrides down here?
There was a problem hiding this comment.
That might be a good idea actually. Will probably need to work it into ThanosStack cr
|
Part of #2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.