Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the error message #23

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Fix the error message #23

merged 2 commits into from
Nov 7, 2024

Conversation

hsjoihs
Copy link
Contributor

@hsjoihs hsjoihs commented Nov 6, 2024

  • 文字「が」見つかる (名詞 + be found) / 文字「を」見つける (find + 名詞) のどちらかであるべきなので、このような際のエラーメッセージに典型的に用いられる "Cannot find + 名詞" と表現。
  • 両者を見せるエラーメッセージは This pair of (punctuation) marks などとするのがよい（cf. https://en.wikipedia.org/wiki/Guillemet ）ので、その旨修正。

@hsjoihs
Fix the error message
34046ad 
- 文字「が」見つかる (名詞 + be found) / 文字「を」見つける (find + 名詞) のどちらかであるべきなので、このような際のエラーメッセージに典型的に用いられる "Cannot find + 名詞" と表現。
- 両者を見せるエラーメッセージは This pair of (punctuation) marks などとするのがよい（cf. https://en.wikipedia.org/wiki/Guillemet ）ので、その旨修正。
@azu azu added the Type: Documentation Documentation only changes label Nov 6, 2024
@azu
Copy link
Member

azu commented Nov 6, 2024

テストも修正が必要そうです

@azu azu merged commit b3bbe21 into textlint-rule:master Nov 7, 2024
2 checks passed
@azu
Copy link
Member

azu commented Nov 7, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Documentation Documentation only changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsjoihs @azu