Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add optional wifi ap pw #56

Closed
wants to merge 2 commits into from

Conversation

docgalaxyblock
Copy link
Contributor

I added a wifi ap pw option to the substitutions.
The default is your current state of no pw.

I added a warning comment that if the user forget the pw it is required to open up the device again.
Therefore I added the hint to use the Setup code you can find at the Minis backside as the ap pw.

@docgalaxyblock docgalaxyblock force-pushed the main branch 2 times, most recently from b472f72 to 2c91ed1 Compare June 22, 2024 14:58
@klaasnicolaas
Copy link
Collaborator

I doubt whether it is useful to put these kinds of optional things in the YAML config, this could cause problems if a user in the future flashes their onju voice via ESP web tools.

@docgalaxyblock
Copy link
Contributor Author

@klaasnicolaas What scenario do you have in mind? Cause after my change the default is still no ap pw at all.

@klaasnicolaas
Copy link
Collaborator

My advice would be not to merge optional code, if users would like to use a AP password they can add and compile it themselves.

./Klaas

@docgalaxyblock
Copy link
Contributor Author

@tetele What is your opinion?

My intention is to give users a hint regarding securing up their onju fallback ap.

@tetele
Copy link
Owner

tetele commented Jul 7, 2024

AP password is very rarely needed and, if so, the user should probably go for a custom config. I agree with Klaas.

@tetele tetele closed this Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants