Fix volume display

tetele · Jan 15, 2025 · a3a54fd · a3a54fd
1 parent c67c00a
commit a3a54fd
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 13 deletions.
diff --git a/esphome/onju-modules/base.yaml b/esphome/onju-modules/base.yaml
@@ -225,8 +225,8 @@ script:
 
   - id: control_led_volume_touched
     then:
-      - lambda: |
-          id(volume_touched) = false;
+      - lambda: id(volume_touched) = false;
+      - script.execute: control_led
 
   - id: control_led_voice_assistant_waiting_for_command_phase
     then: []

diff --git a/esphome/onju-modules/media_player.yaml b/esphome/onju-modules/media_player.yaml
@@ -13,17 +13,13 @@ media_player:
             float new_volume = id(onju_out).volume;
             if(abs(new_volume-old_volume) > 0.0001) {
               if(old_volume != -1) {
-                id(show_volume) = true;
+                id(volume_touched) = true;
                 id(control_led)->execute();
               }
             }
             old_volume = new_volume;
 
 globals:
-  - id: show_volume
-    type: bool
-    restore_value: no
-    initial_value: "false"
 
 light:
   - id: !extend top_led
@@ -56,24 +52,25 @@ script:
           id: onju_out
           volume: !lambda return clamp(id(onju_out).volume+volume, 0.0f, 1.0f);
       - lambda: |
-          id(show_volume) = true;
+          // Required for when volume is changed externally
+          id(volume_touched) = true;
       - script.execute: control_led
 
-  - id: !extend control_led_volume_touched
+  - id: !remove control_led_volume_touched
+  - id: control_led_volume_touched
+    mode: restart
     then:
       - if:
           condition:
-            lambda: "return id(show_volume);"
+            lambda: "return id(volume_touched);"
           then:
             - light.turn_on:
                 id: top_led
                 effect: show_volume
             - delay: 1s
             - lambda: |
-                id(show_volume) = false;
+                id(volume_touched) = false;
             - script.execute: control_led
-          else:
-            - light.turn_off: top_led
 
 binary_sensor:
   - id: !extend volume_down