fix: use valid config type for supporting both ESLint v8 and v9 #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gareth Jones <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #976 +/- ##
=======================================
Coverage 96.27% 96.27%
=======================================
Files 46 46
Lines 2472 2472
Branches 1025 1030 +5
=======================================
Hits 2380 2380
Misses 92 92 ☔ View full report in Codecov by Sentry. |
MichaelDeBoey
approved these changes
Dec 6, 2024
Belco90
approved these changes
Dec 6, 2024
|
🎉 This PR is included in version 7.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks
Changes
Linter.FlatConfigtype to ensure compatibility with both ESLint v8 and v9Context
#973 incorrectly changed this probably because
Linter.FlatConfigis marked as deprecated in v9, but it's the correct type to be using when supporting both v8 and v9 because@types/eslint(for v8)Linter.Configmaps to legacy config - so right now the actual types forflat/*will change depending on the version of ESLint you've got installed.