Allow non-NIST-P256 TLS server keys #360
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a regression in a safety check on the TLS key that prevented the HTTP proxy server from launching.
The intended purpose of the safety check is to verify that the user is not using the same key as both a TLS server key and a command-authentication key. The code tries to load the TLS key as a command-authentication key, and then compares it with the actual command-authentication key. If the loading step fails because the TLS key is not a NIST-P256 key, then everything is fine. There's no way it could be being misued. However, a loading failure was being treated as a fatal error.
Fixes #359
Type of change
Please select all options that apply to this change:
Checklist:
Confirm you have completed the following steps: