Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more fields, available in 2024.44.32 #275

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

patrickdemers6
Copy link
Collaborator

Description

Adding more fields.

  • LocatedAtHome
  • LocatedAtWork
  • LocatedAtFavorite
  • SettingDistanceUnit
  • SettingTemperatureUnit
  • Setting24HourTime
  • SettingTirePressureUnit
  • SettingChargeUnit
  • ClimateSeatCoolingFrontLeft
  • ClimateSeatCoolingFrontRight

Type of change

Please select all options that apply to this change:

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

Checklist:

Confirm you have completed the following steps:

  • My code follows the style of this project.
  • I have performed a self-review of my code.
  • I have made corresponding updates to the documentation.
  • I have added/updated unit tests to cover my changes.
  • I have added/updated integration tests to cover my changes.

@patrickdemers6 patrickdemers6 merged commit 4034cea into teslamotors:main Dec 18, 2024
1 check passed
@jbanyer
Copy link

jbanyer commented Dec 18, 2024

Nice!

Do the Located* fields require vehicle_location scope?

Do they cause the "location tracking" icon to be displayed constantly in the vehicle, as the Location field does?

@patrickdemers6
Copy link
Collaborator Author

Hey @jbanyer
These fields provide information about the vehicle's location through booleans. They do not reveal the vehicle's actual location, so they do not require location scope and do not show the icon.

@rawmean
Copy link

rawmean commented Dec 18, 2024

Thanks for adding these.
Is there a better way for devs to become aware of these changes (other than monitoring pull requests)?
When these fields are added, devs must wait for their car to get the associated car firmware before being able to test it. This can take a while. Can devs somehow register their VINs to get the associated update sooner to test these changes?

Are you planning to populate display_name? It is currently populated as (even in the recent holiday update):
{'key': 'VehicleName', 'value': {'invalid': True}

@stx
Copy link

stx commented Dec 31, 2024

@patrickdemers6 Looks like this has been merged for awhile. Can you tag a release with this?

@patrickdemers6
Copy link
Collaborator Author

Published v0.4.1 @stx

Happy New Years 🎉

@stx
Copy link

stx commented Dec 31, 2024

@patrickdemers6 You too. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants