Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace cross join with left join #4463

Merged
merged 2 commits into from
Jan 3, 2025
Merged

replace cross join with left join #4463

merged 2 commits into from
Jan 3, 2025

Conversation

swiffer
Copy link
Contributor

@swiffer swiffer commented Jan 1, 2025

cross join will still lead to empty result set if at least one of the tables is not returning a result

@netlify Netlify
Copy link

netlify bot commented Jan 1, 2025 •
edited
Loading

✅ Deploy Preview for teslamate ready!

Name Link
🔨 Latest commit 02f1db2
🔍 Latest deploy log https://app.netlify.com/sites/teslamate/deploys/67756f3d2f064f00080b1306
😎 Deploy Preview https://deploy-preview-4463--teslamate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@swiffer swiffer marked this pull request as draft January 1, 2025 13:45
@swiffer swiffer mentioned this pull request Jan 1, 2025
Closed
1 task
@swiffer swiffer marked this pull request as ready for review January 1, 2025 16:39
@swiffer
Copy link
Contributor Author

swiffer commented Jan 1, 2025 •
edited
Loading

lgtm, changelog entry from PR #4448 can be reused, that pr was incomplete

@JakobLichterfeld JakobLichterfeld added the area:dashboard Related to a Grafana dashboard label Jan 3, 2025
JakobLichterfeld
JakobLichterfeld approved these changes Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@JakobLichterfeld JakobLichterfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, ty!

@JakobLichterfeld JakobLichterfeld merged commit 1a220d9 into teslamate-org:master Jan 3, 2025
15 checks passed
@swiffer swiffer deleted the replace-cross-join branch January 3, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakobLichterfeld JakobLichterfeld JakobLichterfeld approved these changes

Assignees
No one assigned
Labels
area:dashboard Related to a Grafana dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swiffer @JakobLichterfeld