-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update Grafana to 11.4.0 #4299
Conversation
✅ Deploy Preview for teslamate ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Works currently in 1.30.1. Imagine that is a side effect from Grafana 11.3. |
yes but for me it shows two rows with two tables each (two cars). i think that was not the intention. |
8452b82
to
33bc9f2
Compare
76dfa49
to
69c8b97
Compare
@JakobLichterfeld - i would prefer getting this merged with the temp fixes to stay up 2 date (and for me getting this branch integrated to stop keeping it up 2 date). there shouldn't be any regressions now. see comments for specific changes done. |
69c8b97
to
8b9e56b
Compare
😞 back to draft, featue toggles currently cannot be disabled by env vars: |
Damm, was about to start testing right now |
8b9e56b
to
230f017
Compare
283de20
to
ed464e9
Compare
e5e02df
to
4df3df6
Compare
@JakobLichterfeld - figured out what was causing the links between dashboards no longer working correctly. it's caused by an experimental config setting. updated the PR description as well as the grafana tracking issue and disabled the setting in the dockerfile (adding a comment there as well). with most of the dashboard work beeing done in #4338 this one is a simple version bump to grafana 11.3.1 (latest). as recommended this is the first patch release of 11.3.0. the next bump will most likely happen 28th of january (11.4.1) if everything goes as planned: https://grafana.com/docs/grafana/latest/upgrade-guide/when-to-upgrade/#when-to-expect-releases |
(not stressing!) - ready to be merged, don't know if that was clear from my last comment. |
Thanks for reminder.
In fact, it was not clear to me if we could merge this without the other PR related to Grafana 11.3, which I either confused or no longer exists. |
You remember correctly - most of the work of the previous 11.3 PR was included in #4338 - i reused this one for the simple bump to 11.3.1. the only remaining regression i noticed has been mitigated (dashboard links not working with the experimental config setting i described above). |
a086e4f
to
451434d
Compare
Once again: Thanks for your great efforts! I currently test all dashboards. And will post my findings here. |
In Charges, when clicking on the first charge it does not show full data of that charge (no data for charge details, err in charging curve). It seems like the the url is misformed, v1.32.0 this PR: Edit: same for drives and drives details |
Rest is perfect! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see #4299 (comment)
451434d
to
e56b745
Compare
@JakobLichterfeld - sorry not quickly fixing that yesterday, it was light show / event day ;) I temporarily reenabled the browser dateformat setting in env to see if it's solved in 11.4.0 and forgot to disable the env setting again after checking it's not. So, force pushed now and your finding you should be mitigated again. lgtm 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, ty. Successfully tested with charges, drives, timeline, trips and statistics
Upgrades Grafana to 11.4.0. Grafana switched to scenes powered dashboards for which the experimental setting date_formats.use_browser_locale is breaking timerange selector & urls containing absolute time ranges.
Therefore date_formats.use_browser_locale has been temporarily disabled (see comment in Dockerfile).
Tracking issue: grafana/grafana#95209