fix: for drives not showing if duration < 1 minute and feat: add max speed in drives dashboard #4284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for teslamate ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
swiffer
changed the title
JakobLichterfeld
changed the title
JakobLichterfeld
added
kind:bug
JakobLichterfeld
approved these changes
Oct 20, 2024
JakobLichterfeld
approved these changes
Oct 20, 2024
swiffer
added a commit
to swiffer/teslamate
that referenced
this pull request
Oct 29, 2024
swiffer
added a commit
to swiffer/teslamate
that referenced
this pull request
Oct 31, 2024
swiffer
added a commit
to swiffer/teslamate
that referenced
this pull request
Nov 1, 2024
swiffer
added a commit
to swiffer/teslamate
that referenced
this pull request
Nov 5, 2024
JakobLichterfeld
pushed a commit
that referenced
this pull request
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a fix for drives not showing in the drives dashboard if the
duration_minis 0.fallback to diff of
end_date - start_dateinstead to calculateavg_speed.this brings number of drives in line with drive stats dashboard.
in addition cherry pick changes from #4267