Update charging-stats for handling suc cost mixed with AC charge on TWC #4137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some AC charging using a Tesla Wall Connector are selected as SUC charges and they make the total SUC cost wrong.
✅ Deploy Preview for teslamate ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@swiffer or @jheredianet : May I ask you to review this PR? |
|
@JakobLichterfeld This looks good to me. I don't have a Tesla Wall Connector, but the where condition is ok to avoid confusing between a Tesla SuperCharger and a Tesla Wall Connector. |
JakobLichterfeld
approved these changes
Aug 23, 2024
JakobLichterfeld
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some AC charging using a Tesla Wall Connector are selected as SUC charges and they make the total SUC cost wrong.