Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small visual distinguish between AC & DC charging in charges dashboard and unification of the DC coloring in all dashboards #4124

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

stauffenberg2020
Copy link
Contributor

This commit just adds a different colour to the DC charges so that it can be easily visualized

image

Copy link

netlify bot commented Aug 5, 2024

Deploy Preview for teslamate ready!

Name Link
🔨 Latest commit a627682
🔍 Latest deploy log https://app.netlify.com/sites/teslamate/deploys/66b22edb3765a300084ba33c
😎 Deploy Preview https://deploy-preview-4124--teslamate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JakobLichterfeld JakobLichterfeld added the area:dashboard Related to a Grafana dashboard label Aug 6, 2024
@JakobLichterfeld
Copy link
Collaborator

JakobLichterfeld commented Aug 6, 2024

Thanks for your suggestion!

May I ask to align the color to Charging Stats?
Edit: In Battery Health Dashboard, it seems like a different color as well. So we need to align it on all dashboards.

@stauffenberg2020
Copy link
Contributor Author

Hi @JakobLichterfeld , I think charging stats is the only one with a yellow color for DC, Whereas both the suggested change and Battery health have orange color for DC. So should I change the charging stats dashboard to orange so that DC is represented by orange color in all these 3 dashboards?

@JakobLichterfeld
Copy link
Collaborator

So should I change the charging stats dashboard to orange so that DC is represented by orange color in all these 3 dashboards?

That would be awesome!

Copy link
Collaborator

@JakobLichterfeld JakobLichterfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your change

grafana/dashboards/charges.json Outdated Show resolved Hide resolved
@JakobLichterfeld JakobLichterfeld changed the title Small visual distinguish between AC & DC charging Small visual distinguish between AC & DC charging and unification of the DC colering in all dashboards Aug 6, 2024
@stauffenberg2020
Copy link
Contributor Author

I have made the changes. I do not know why it still shows as if you have further requested changes. Can you please check and let me know if I have done it correctly?

Copy link
Collaborator

@JakobLichterfeld JakobLichterfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now it looks perfect

@JakobLichterfeld JakobLichterfeld changed the title Small visual distinguish between AC & DC charging and unification of the DC colering in all dashboards small visual distinguish between AC & DC charging in charges dashboard and unification of the DC coloring in all dashboards Aug 6, 2024
@JakobLichterfeld JakobLichterfeld merged commit 24890cd into teslamate-org:master Aug 6, 2024
12 checks passed
@sdwalker
Copy link
Contributor

sdwalker commented Aug 7, 2024

The battery health and charge pie chart greens are different as well

I agree with getting a consistent shade of colors used throughout all of the dashboards

@stauffenberg2020 stauffenberg2020 mentioned this pull request Oct 27, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dashboard Related to a Grafana dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants