Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downgrade grafana until maps issue in upstream grafana is resolved #4071

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

swiffer
Copy link
Contributor

@swiffer swiffer commented Jul 9, 2024

before releasing this potentially as 1.30.1 please check if maps are working fine again

#4019 (comment)

sorry rushing the grafana update. always try to stay on latest. (at least 1.30.1 would bring some grafana localization improvements as well ;))

once grafana 11.1.1 is released we can upgrade again as it will include this fix: grafana/grafana#89248

Copy link

netlify bot commented Jul 9, 2024

Deploy Preview for teslamate ready!

Name Link
🔨 Latest commit fa3dfcc
🔍 Latest deploy log https://app.netlify.com/sites/teslamate/deploys/668d8baecc26eb0008f5f0bb
😎 Deploy Preview https://deploy-preview-4071--teslamate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@swiffer swiffer closed this Jul 9, 2024
@swiffer swiffer reopened this Jul 9, 2024
@swiffer
Copy link
Contributor Author

swiffer commented Jul 9, 2024

I think I've edited two dashboards after upgrading to 11.1.0 - are these still working fine after downgrade? Can test tomorrow and change dashboard yank if needed...

@brianmay
Copy link
Collaborator

brianmay commented Jul 10, 2024

We should put a link to the upstream grafana issue. Assuming there is one. If there isn't maybe we need to create one.

LATER: I think link is grafana/grafana#89248

@swiffer
Copy link
Contributor Author

swiffer commented Jul 10, 2024

looks good to me - dashboards still working

@JakobLichterfeld JakobLichterfeld changed the title downgrade grafana until maps issue is resolved downgrade grafana until maps issue in upstream grafana is resolved Jul 10, 2024
@JakobLichterfeld JakobLichterfeld merged commit 4d152a3 into teslamate-org:master Jul 10, 2024
22 checks passed
@JakobLichterfeld JakobLichterfeld added the kind:bug Something isn't working label Jul 10, 2024
@cwanja
Copy link
Collaborator

cwanja commented Jul 10, 2024

Guess I am confused. I thought we were not downgrading based upon discussions in #4019. Specifically, #4019 (comment)

@JakobLichterfeld
Copy link
Collaborator

Guess I am confused.

Now I'm confused as well. Was on mobile yesterday evening and later agreed to downgrade by today.

@cwanja
Copy link
Collaborator

cwanja commented Jul 10, 2024

Oh well. Release is out there. No harm, less issues and discussions.

We can close the open / pinned issue when the new Grafana release happens.

@JakobLichterfeld
Copy link
Collaborator

Yeah, overall I think this is the best User Experience and Developer Experience :-)

@swiffer
Copy link
Contributor Author

swiffer commented Jul 10, 2024

https://grafana.com/blog/2024/07/09/upgrade-with-confidence-strategies-for-updating-your-self-hosted-grafana-instance/

Grafana 11.1.1 will be released in approx. 2 weeks. So think it's good to have that v1.30.1 release out for that period.

If I got their "Self-managing upgrade strategies" section right Minor releases should be pushed to prod after first patch release (e.g. recommended would have been to wait for 11.1.1 and use 11.1.0 in testing only (keep that PR as a draft)).

Will ensure we follow this path with the next update ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants