Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add yeec and leex compilers to mix.exs #3941

Closed
wants to merge 2 commits into from

Conversation

JakobLichterfeld
Copy link
Collaborator

To fix the linter warnings, see for example here: https://github.com/teslamate-org/teslamate/actions/runs/9380988328

@JakobLichterfeld JakobLichterfeld requested a review from brianmay June 5, 2024 09:54
@JakobLichterfeld JakobLichterfeld added enhancement New feature or request elixir Pull requests that update Elixir code labels Jun 5, 2024
Copy link

netlify bot commented Jun 5, 2024

Deploy Preview for teslamate ready!

Name Link
🔨 Latest commit 08c5b98
🔍 Latest deploy log https://app.netlify.com/sites/teslamate/deploys/6660362f6d21f10008ce3711
😎 Deploy Preview https://deploy-preview-3941--teslamate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brianmay
Copy link
Collaborator

brianmay commented Jun 5, 2024

I suspect the problem is in compiling one/more dependencias. Can't fix it here :-(

In general I think the Elxir community aren't particularly proactive about removing compiler warnings - have a look at the compiler logs.

Although this could also be because we are using old versions of packages (I suspect probably).

It could also be sign that the packages we rely on are no longer being actively maintained.

@JakobLichterfeld
Copy link
Collaborator Author

At least the linter warnings dissapear with these changes.

From time to time I remember your idea of rewriting in rust.

@brianmay
Copy link
Collaborator

brianmay commented Jun 6, 2024

Are you sure that they disappeared?

I still see them. e.g. https://github.com/teslamate-org/teslamate/actions/runs/9382022104?pr=3941

@JakobLichterfeld
Copy link
Collaborator Author

Are you sure that they disappeared?

I still see them. e.g. https://github.com/teslamate-org/teslamate/actions/runs/9382022104?pr=3941

You are right, damn. I looked in the single job :-(

@JakobLichterfeld JakobLichterfeld deleted the ci-add-compilers branch June 9, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
elixir Pull requests that update Elixir code enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants