Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Battery Health estimations based on derivate efficiency #3531

Conversation

jheredianet
Copy link
Contributor

This is an improve on Battery Health estimations, based on derivate efficiency discussed here #3486 (comment)

In the other hand, I've removed the same dashboard for LFP batteries since it is not worth having 2 dashboards available as explained here #3513 (reply in thread) at least until we have this feature (#3438) implemented in Teslamate.

Copy link

netlify bot commented Dec 1, 2023

Deploy Preview for teslamate ready!

Name Link
🔨 Latest commit e0a10e6
🔍 Latest deploy log https://app.netlify.com/sites/teslamate/deploys/657285d390b29400089d8ed4
😎 Deploy Preview https://deploy-preview-3531--teslamate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JakobLichterfeld JakobLichterfeld added the area:dashboard Related to a Grafana dashboard label Dec 5, 2023
@JakobLichterfeld
Copy link
Collaborator

JakobLichterfeld commented Dec 5, 2023

Thanks for your work!

In the other hand, I've removed the same dashboard for LFP batteries since it is not worth having 2 dashboards available as explained here #3513 (reply in thread) at least until we have this feature (#3438) implemented in Teslamate.

However, breaking backwards compatibility is not an option.

@JakobLichterfeld JakobLichterfeld added the closed:wontfix This will not be worked on label Dec 5, 2023
@jheredianet
Copy link
Contributor Author

However, breaking backwards compatibility is not an option.
Totally agree, but this is not the case. There is no breaking backwards compatibility. Please check it further.

@jheredianet jheredianet mentioned this pull request Dec 7, 2023
1 task
@JakobLichterfeld
Copy link
Collaborator

Totally agree, but this is not the case. There is no breaking backwards compatibility. Please check it further.

For sure, you remove Dashboards, without including a solution for #3438

@jheredianet
Copy link
Contributor Author

Totally agree, but this is not the case. There is no breaking backwards compatibility. Please check it further.

For sure, you remove Dashboards, without including a solution for #3438

Ok, I've made an update. No removed Battery Health LFP dashboard.
As the title says, this is a PR for improving estimations, based on derivate efficiency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dashboard Related to a Grafana dashboard closed:wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants