-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change to dateTimeAsSystem and enable date formats #3053
Change to dateTimeAsSystem and enable date formats #3053
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR.
lgtm, test needed
Happy to test that. @jlestel do we have a Grafana image for this PR? |
Not yet! CI fusion failed last night, we still need to take some time to test it. I hope it will be possible soon! |
Does it mean, you can set the date format with GF_DATE_FORMATS_FULL_DATE in your docker-compose.yaml? Hmmm, DateTimeSystem gives me 2023-11-12 21:57:52. Whereas DateTimeLocal gives me 12.11.2023 21:57:42. I think, I'd prefer the latter... |
Please update your branch |
@swiffer is this still needed with our migration to latest grafana? |
there is an experimental browser locale based setting now https://grafana.com/docs/grafana/latest/setup-grafana/configure-grafana/#use_browser_locale i think we should make use of this instead. @jheredianet you have changed it already in your dashboards, right? could you consider changing it back if we go with an ENV setting instead in the grafana image? |
Yes, I have. Sure, no problem. It's a good idea. |
Close this, as replaced by #4064 |
Gives the ability to have custom date formats on dashboards.