Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Add ability to configure IPAM exclusively for IPv4 or IPv6 #1155

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

sebastianczech
Copy link
Contributor

Description

PR delivers features to configure IPAM exclusively for IPv4 or IPv6 - previously it was 1 variable used for both IP protocols, so IPAM could be used for both or neither.

Motivation and Context

#1153

Breaking Changes

Previously it was defined 1 variable use_ipam_pool used for both IP protocol. In order to distinguish to which protocol IPAM should be used, there were introduced 2 new variables use_ipv4_ipam_pool and use_ipv6_ipam_pool (old variable use_ipam_pool was removed).

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@sebastianczech sebastianczech changed the title feat: Add ability to configure IPAM exclusively for IPv4 or IPv6 feat!: Add ability to configure IPAM exclusively for IPv4 or IPv6 Jan 4, 2025
@Vinoth-S15
Copy link

The changes are satisfactory to me

@bryantbiggs
Copy link
Member

you need to use enable_ipv6 to toggle on IPv6 - I don't know that these breaking changes are warranted at this time

@sebastianczech
Copy link
Contributor Author

sebastianczech commented Feb 13, 2025

As far as I understand, when enable_ipv6 is set to true and use_ipam_pool is also set to true, then IPAM is enabled for both IPv4 and IPv6. In issue #1153, there was a need to have IPAM exclusively for IPv6 CIDR allocation, not for IPv4. This is most likely an edge case, but if you don't see a need to implement it and want to avoid breaking changes, please close this PR, without merging it. I prepared it only because of the need mentioned in issue #1153.

@Vinoth-S15
Copy link

We might need IPAM only for IPv6 and not for IPv4. Enabling IPAM for IPv4 will monitor all the private IPs it manages, which adds more cost.

Ex:
For 5,000 private IPs managed by AWS IPAM, assuming all are active, the monthly cost can be estimated as follows.

Hourly Cost per IP: $0.00027 (this rate may vary by Region)
Total Hourly Cost for 5,000 IPs: 5,000 IPs × $0.00027/IP = $1.35
Monthly Cost: $1.35/hour × 24 hours/day × 30 days/month = $972

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants