Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace noop mempool with sender nonce mp #283

Merged

Conversation

javiersuweijie
Copy link
Member

This might cause blocks proposals to be larger than it should which causes validators to reject block proposals.

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.48%. Comparing base (7dce06b) to head (bf1c53b).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release/v2.10     #283      +/-   ##
=================================================
+ Coverage          70.41%   70.48%   +0.06%     
=================================================
  Files                 45       45              
  Lines               2096     2097       +1     
=================================================
+ Hits                1476     1478       +2     
+ Misses               453      452       -1     
  Partials             167      167              
Files Coverage Δ
app/app.go 74.85% <100.00%> (+0.29%) ⬆️

... and 1 file with indirect coverage changes

@javiersuweijie javiersuweijie force-pushed the fix/v2.10/proposals-exceed-max-gas-limit branch from fdf314a to bf1c53b Compare March 21, 2024 08:26
@javiersuweijie
Copy link
Member Author

Tests passed locally

--- PASS: TestPMF (149.09s)
    --- PASS: TestPMF/multi-hop_a->b->c->d (28.31s)
PASS
ok      github.com/terra-money/core/interchaintest      151.539s

@javiersuweijie javiersuweijie merged commit 6f81420 into release/v2.10 Mar 21, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants