-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add packages: pianobar, libao #2641
Conversation
Oops! It seems that too many packages need to be built, the docker stopped the job after the log length extended the limit of 4M :( |
packages/libao/ao_private.h.patch
Outdated
|
||
#ifndef AO_SYSTEM_CONFIG | ||
-#define AO_SYSTEM_CONFIG "/etc/libao.conf" | ||
+#define AO_SYSTEM_CONFIG "/data/data/com.termux/files/user/etc/libao.conf" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use @TERMUX_PREFIX@
instead of data/data/com.termux/files/usr
, it is sed'ed before the patch is applied in build-package.sh.
packages/pianobar/Makefile.patch
Outdated
# makefile of pianobar | ||
|
||
-PREFIX:=/usr/local | ||
+PREFIX:=/data/data/com.termux/files/usr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same with the prefix here, please use @TERMUX_PREFIX@.
packages/libao/build.sh
Outdated
} | ||
|
||
termux_step_post_make_install () { | ||
#genrate libao config file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny typo, generate
packages/pianobar/build.sh
Outdated
TERMUX_PKG_HOMEPAGE=https://6xq.net/pianobar/ | ||
TERMUX_PKG_DESCRIPTION="pianobar is a free/open-source, console-based client for the personalized online radio Pandora." | ||
TERMUX_PKG_VERSION=2018.06.22 | ||
TERMUX_PKG_REVISION=1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to set TERMUX_PKG_REVISION for a new package (and counter starts from 0).
Looks good! |
@Grimler91 |
The choppy sound issue is solved by adding a new thread for pianobar's player. |
Reopened here |
@tcaddy
Finished here.
But the sound is a little choppy on my aarch64 device, may be the buffer underrun issue of pulseaudio in termux.