Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add packages: pianobar, libao #2641

Closed
wants to merge 4 commits into from
Closed

Add packages: pianobar, libao #2641

wants to merge 4 commits into from

Conversation

edward-p
Copy link
Contributor

@edward-p edward-p commented Jul 10, 2018

@tcaddy
Finished here.
But the sound is a little choppy on my aarch64 device, may be the buffer underrun issue of pulseaudio in termux.

@edward-p
Copy link
Contributor Author

Oops! It seems that too many packages need to be built, the docker stopped the job after the log length extended the limit of 4M :(


#ifndef AO_SYSTEM_CONFIG
-#define AO_SYSTEM_CONFIG "/etc/libao.conf"
+#define AO_SYSTEM_CONFIG "/data/data/com.termux/files/user/etc/libao.conf"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use @TERMUX_PREFIX@ instead of data/data/com.termux/files/usr, it is sed'ed before the patch is applied in build-package.sh.

# makefile of pianobar

-PREFIX:=/usr/local
+PREFIX:=/data/data/com.termux/files/usr
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with the prefix here, please use @TERMUX_PREFIX@.

}

termux_step_post_make_install () {
#genrate libao config file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny typo, generate

TERMUX_PKG_HOMEPAGE=https://6xq.net/pianobar/
TERMUX_PKG_DESCRIPTION="pianobar is a free/open-source, console-based client for the personalized online radio Pandora."
TERMUX_PKG_VERSION=2018.06.22
TERMUX_PKG_REVISION=1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to set TERMUX_PKG_REVISION for a new package (and counter starts from 0).

@Grimler91
Copy link
Member

Looks good!
Yeah the build process we use tend to generate a huge log unfortunately

@edward-p
Copy link
Contributor Author

@Grimler91
Fixed.

@edward-p
Copy link
Contributor Author

edward-p commented Jul 28, 2018

The choppy sound issue is solved by adding a new thread for pianobar's player.
And @tomty89 fixed pulse-plugin-of-libao's buffer issue. See PromyLOPh/pianobar#664
Reopen when the upstream merged and next release.

@edward-p edward-p closed this Jul 28, 2018
@edward-p
Copy link
Contributor Author

Reopened here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants