Get rid of repeated web3.eth.getChainId() calls #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diwu1989
commented
Feb 15, 2022
| @@ -17,21 +17,23 @@ export abstract class Pair { | |||
| public pairKey: string | null = null; | |||
| public tokenA: Address = ""; | |||
| public tokenB: Address = ""; | |||
| protected swappaPairAddress: Address = ""; | |||
| private swappaPairAddress: Address = ""; | |||
There was a problem hiding this comment.
make private now that the child classes do not need to set this directly anymore
diwu1989
commented
Feb 15, 2022
|
|
||
| public async init(): Promise<void> { | ||
| const r = await this._init() | ||
| this.pairKey = r.pairKey | ||
| this.tokenA = r.tokenA | ||
| this.tokenB = r.tokenB | ||
| this.swappaPairAddress = r.swappaPairAddress |
There was a problem hiding this comment.
constructor should have already set up the correct pair addr
diwu1989
commented
Feb 15, 2022
| @@ -25,6 +25,7 @@ export class RegistryUniswapV2 extends Registry { | |||
| } | |||
|
|
|||
| findPairs = async (tokenWhitelist: Address[]): Promise<Pair[]> => { | |||
| const chainId = await this.web3.eth.getChainId() | |||
There was a problem hiding this comment.
make each registry as part of findPairs grab the chainID exactly once, and instantiate all pairs with that chainId
diwu1989
commented
Feb 15, 2022
| @@ -17,12 +17,7 @@ interface AddressesByNetwork { | |||
| alfajores?: Address, | |||
| } | |||
|
|
|||
| export const selectAddress = async (web3: Web3, addresses: AddressesByNetwork) => { | |||
There was a problem hiding this comment.
selectAddress is sync now that we require the chainId to be passed in directly
caller is responsible to make the minimal number of getChainId() calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every single pair was making a getChainID() call to load its network address inside
init().This is unnecessary, lift it up to the registry level as part of
findPairs()to retrieve the chain ID and pass into constructor of Pair.Make initialization faster and more scalable for thousands of pairs.
This also makes it easier for me to bulk instantiate and refresh all pairs now that the swappa pair address is not part of
async init()