Uniswap registry fetch using all pairs by default #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uniswap registry was using pairwise combination to fetch pairs by default:
if (!this.opts?.fetchUsingAllPairs)
,fetchUsingAllPairs === undefined
and negated become trueGiven the number of tokens in the default token whitelist is pretty large now, this causes over 2k calls into the factory.
The actual number of pairs created by the factories are a lot smaller:
We can save the calls if we default
fetchUsingAllPairs
totrue