Manual uplift (also adds support for int32 buffers) #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgligorijevicTT
requested review from
ajakovljevicTT,
kmitrovicTT and
mrakitaTT
as code owners
|
||||||||||||||
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #292 +/- ##
==========================================
- Coverage 78.09% 77.97% -0.12%
==========================================
Files 21 21
Lines 986 990 +4
==========================================
+ Hits 770 772 +2
- Misses 216 218 +2 ☔ View full report in Codecov by Sentry. |
ajakovljevicTT
approved these changes
Mar 3, 2025
sgligorijevicTT
changed the title
sgligorijevicTT
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uplifts tt-mlir to the latest version and adds support for int32 buffers.
It also skips a couple of dtype conversion tests.
test_convert[int64-uint16]was broken from the start and was passing erroneously before.test_convert[int32-uint16]appears to be a real regression, we will have to investigate what's going on later.Related issues: #293 #294