Do not trigger CI when .md files are changed #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsumrakTT
requested review from
ajakovljevicTT,
kmitrovicTT and
mrakitaTT
as code owners
|
||||||||||||||
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #290 +/- ##
=======================================
Coverage 77.97% 77.97%
=======================================
Files 21 21
Lines 990 990
=======================================
Hits 772 772
Misses 218 218 ☔ View full report in Codecov by Sentry. |
… pass so PR can be accepted
mrakitaTT
reviewed
Feb 28, 2025
|
When merged, I had to test it further |
…ild and test but check-all-green can still pass so PR could be merged
mrakitaTT
approved these changes
Mar 3, 2025
Comment on lines
+44
to
+48
| if [ "$all_match" = true ]; then | ||
| echo "skip=true" >> "$GITHUB_OUTPUT" | ||
| else | ||
| echo "skip=false" >> "$GITHUB_OUTPUT" | ||
| fi |
There was a problem hiding this comment.
Can this be replaced with echo "skip="$all_match >> "$GITHUB_OUTPUT"?
There was a problem hiding this comment.
I did it in this way because we might need to emit some data for collection in case build is skipped. I'll check with @vmilosevic and change it accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
files to ignore: *.md, *.gitignore, LICENSE
closes #295