Adding input sharding collection in ModuleBuilder #289
+77
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajakovljevicTT
requested review from
kmitrovicTT and
mrakitaTT
as code owners
|
||||||||||||||
kmitrovicTT
reviewed
Mar 3, 2025
src/common/module_builder.cc
Outdated
Comment on lines
178
to
179
| auto shardingAttr = llvm::dyn_cast_if_present<mlir::StringAttr>( | ||
| funcOp.getArgAttr(i, mlir::tt::sharding_utils::kXlaShardingAttr)); |
There was a problem hiding this comment.
Nitpick: can we avoid casting to stringattr and directly convert from the fetched attribute?
There was a problem hiding this comment.
I left it like this so I can use the already made functions in tt-mlir. See: lib/Conversion/StableHLOToTTIR/StableHLOToTTIRPatterns.cpp in tt-mlir
Comment on lines
+42
to
+46
| const std::vector<mlir::tt::sharding_utils::MeshSharding> & | ||
| getInputShardings() const { | ||
| return m_input_shardings; | ||
| } | ||
|
|
There was a problem hiding this comment.
Left a getter there for future use, do you think I should erase it?
ajakovljevicTT
force-pushed
the
ajakovljevic/adding_input_sharding_collection
branch
from
93a81fd to
9ce0256
Compare
ajakovljevicTT
force-pushed
the
ajakovljevic/adding_input_sharding_collection
branch
from
9ce0256 to
260fb4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of adding support for multichip, adding collection of the information about the device sharding of the inputs of the the StableHLO graph during compilation. That way, we will know how to create MultiDevice input tensors when executing.