Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky dtype test #294

Open
sgligorijevicTT opened this issue Mar 3, 2025 · 0 comments
Open

Flaky dtype test #294

sgligorijevicTT opened this issue Mar 3, 2025 · 0 comments

Comments

@sgligorijevicTT
Copy link
Contributor

test_convert[int64-uint16] appears to be copying the behavior of test_convert[int32-uint16] when the entire test_convert.py is ran. Before the latest uplift both of them were passing, after latest uplift both of them are failing on atol(with the exact same atol!!!). Launching just test_convert[int64-uint16] yields a different error message(it errors both before and after uplift). This is possibly related to not cleaning up properly somewhere.
@sgligorijevicTT sgligorijevicTT mentioned this issue Mar 3, 2025
Merged
sgligorijevicTT added a commit that referenced this issue Mar 3, 2025
@sgligorijevicTT
Manual uplift (also adds support for int32 buffers) (#292)
5f758e5 
This PR uplifts tt-mlir to the latest version and adds support for int32
buffers.
It also skips a couple of dtype conversion tests.
`test_convert[int64-uint16]` was broken from the start and was passing
erroneously before. `test_convert[int32-uint16]` appears to be a real
regression, we will have to investigate what's going on later.

Related issues: #293 #294
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sgligorijevicTT