Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove get_virtual_soc_descriptors #520

Merged
merged 4 commits into from
Feb 25, 2025
Merged

Remove get_virtual_soc_descriptors #520

merged 4 commits into from
Feb 25, 2025

Conversation

broskoTT
Copy link
Contributor

@broskoTT broskoTT commented Feb 7, 2025

Issue

Part of #248

Description

This map usage is removed from tt-metal.
Alternative is to get_target_device_ids and then get_soc_descriptor()

List of the changes

  • Removed get_virtual_soc_descriptors
  • Added specific get_soc_descriptor to mockup and simulation
  • Change all relevant usages

Testing

Existing CI tests

API Changes

There will be no breaking API changes after this one is merged: tenstorrent/tt-metal#17645

@broskoTT broskoTT enabled auto-merge (squash) February 25, 2025 11:28
@broskoTT broskoTT merged commit 06f2666 into main Feb 25, 2025
17 of 20 checks passed
@broskoTT broskoTT deleted the brosko/soc_desc_change branch February 25, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants