Fix Metal build: put detect_arch() back #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This family of functions was removed during a refactor. Metal is relying on one of them. This change reintroduces it.
broskoTT
reviewed
Oct 16, 2024
|
I was just wondering where this function went lol |
broskoTT
approved these changes
Oct 17, 2024
broskoTT
added a commit
that referenced
this pull request
Oct 17, 2024
I've rushed into merging Joel's change #175 Seems like there were two detect_arch() calls which were needed. This time I've manually verified that tt_metal builds with UMD on this branch. I've also added an API test to document this usage, which should be changed, probably to tt::umd::ClusterDescriptor::get_arch(chip_id) or something similar Fixes #171
2 tasks
broskoTT
added a commit
that referenced
this pull request
Dec 4, 2024
### Issue Related to #99 Aftermath of #175 ### Description Make detect_arch available through cluster_descriptor which should be the only real endpoint when reading information about chips in the cluster. ### List of the changes - Removed detect_arch from cluster.h - Added arch map in ClusterDescriptor - Added static tt_ClusterDescriptor::detect_arch which should be used instead of previously defined detect_arch ### Testing Wrote a test which verifies this works as intended ### API Changes This PR has API changes: - [x] tt_metal approved PR pointing to this branch: tenstorrent/tt-metal#15564 - [x] tt_debuda approved PR pointing to this branch: tenstorrent/tt-exalens#201
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This family of functions was removed during a refactor. Metal is relying on one of them. This change reintroduces it.
Fixes #171