Jameszianxu/runtime intermediates #383
Draft
+152
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Register runtime tensor cpp binding (tbd - API for descriptor) and runtime tensor to torch Tensor conversion - Add test codepath to prepopulate intermediate golden map - Add cache for intermediate data incl. golden tensor(s), decomposed ttnn op output tensor(s) as a list - Add post-execution PCC / ATOL comparison
- Use testing goldens in place of real intermediates for verification - Fixup datatype bugs (tuple of tensor vs tensor) - Remove circular dependency in verify.py
jameszianxuTT
force-pushed
the
jameszianxu/runtime_intermediates
branch
from
da6ff94 to
8a8949c
Compare
|
||||||||||||||
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #383 +/- ##
==========================================
- Coverage 75.81% 73.50% -2.31%
==========================================
Files 8 8
Lines 1199 1253 +54
==========================================
+ Hits 909 921 +12
- Misses 290 332 +42 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#260
Problem description
Currently no way to get intermediate ttnn results
from runtime.
What's changed
based on torchfx-ttnn mapping, accounting for decomposition
Checklist