Interim fix for op-by-op parser [#313] #314
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddilbazTT
changed the title
Cannot find root cause - will add safeguards to make sure failure happens without interfering with other jobs
ddilbazTT
force-pushed
the
ddilbaz/op_by_op_parser
branch
from
e560c11 to
078181e
Compare
| @@ -843,5 +861,8 @@ def default(shlo_op, md_data): | |||
|
|
|||
|
|
|||
| if __name__ == "__main__": | |||
| generate_status_report() | |||
There was a problem hiding this comment.
is the order not reversed now? Does that make a difference?
There was a problem hiding this comment.
It is reversed because I do not want process_json_files to be killed by generate_status_report. try-except block should handle this but added it for extra measure.
| (count / total_ops) * 100 if total_ops > 0 else 0 | ||
| ) | ||
| status_report[model_name] = status_percentages | ||
| except Exception as e: |
There was a problem hiding this comment.
We should still fail the job if this doesn't happen, perhaps we can add a test to see if any jsons failed and if they did, assert at the end.
|
||||||||||||||
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #314 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cannot find root cause - will add safeguards to make sure failure happens without interfering with other jobs
Ticket
#313
Problem description
Feb 17 nightly tests rerun attempts 2 and 3 failed during tt-torch/results/parse_op_by_op_results.py -- generate_status_report Rerun attempt 1 has succeded during generate_status_report. Problem cannot be reproduced but added safeguard so that generate_status_report does not interfere with the execution of nightly tests.
What's changed