Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes to model e2e tests #307

Merged
merged 1 commit into from
Feb 16, 2025
Merged

Conversation

jameszianxuTT
Copy link
Contributor

@jameszianxuTT jameszianxuTT commented Feb 15, 2025

Ticket

#256

Problem description

An error introduced in PR#283 breaks nightly model tests. Also, I noticed a few of the tests still have record_property calls.

What's changed

  • Fix segformer test typo breaking nightly tests
  • Remove missed extraneous record_property calls

Checklist

  • New/Existing tests provide coverage for changes

- Fix segformer test typo breaking nightly tests
- Remove missed extraneous record_property calls
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Torch Tests435 ran428 passed7 skipped0 failed
TestResult
No test annotations available

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (2024786) to head (0cf0075).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@     Coverage Diff     @@
##   main   #307   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jameszianxuTT
Copy link
Contributor Author

Nightly tests were manually triggered on this PR to verify the fix and were also successful: https://github.com/tenstorrent/tt-torch/actions/runs/13348990257

@jameszianxuTT jameszianxuTT merged commit cd3124f into main Feb 16, 2025
42 checks passed
@jameszianxuTT jameszianxuTT deleted the jameszianxu/issue-256-fixes branch February 16, 2025 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants