Added decomp for bilinear upsample that uses matmul #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LPanosTT
force-pushed
the
lpanos/custom_bilinear_decomp
branch
3 times, most recently
from
aadbaff to
ba0bb7b
Compare
LPanosTT
force-pushed
the
lpanos/custom_bilinear_decomp
branch
2 times, most recently
from
53cee8f to
618e822
Compare
| @@ -67,6 +68,85 @@ def _extend_context_manager( | |||
| ), "contextmanager unbalanced: popped different that pushed" | |||
|
|
|||
|
|
|||
| # This method is derived from the implementation of jax.image.resize in JAX: | |||
| # https://github.com/jax-ml/jax/blob/354bd5271077654af983965c8e01ee462ce4ce91/jax/_src/image/scale.py#L52 | |||
There was a problem hiding this comment.
What licence is this published under? Do we need to add it to our licence files?
There was a problem hiding this comment.
LPanosTT
force-pushed
the
lpanos/custom_bilinear_decomp
branch
from
618e822 to
f0b1506
Compare
AleksKnezevic
approved these changes
Dec 18, 2024
mmanzoorTT
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added custom decomposition for
aten.upsample_bilinear2dwhich uses matmuls to compute the upsample.Added a
CUSTOM_DECOMPOSITION_TABLEso we can distinguish between which decompositions are ours and which are not.Pass a table to
apply_decompositionsinstead.