Separate workflows for build and running tests. (#19)

Separate workflows for build and running tests
tenstorrent · Nov 14, 2024 · 67c7720 · 67c7720
1 parent 4d55886
commit 67c7720
Show file tree

Hide file tree

Showing 5 changed files with 126 additions and 32 deletions.
diff --git a/.github/on-pr.yml b/.github/on-pr.yml
diff --git a/.github/workflows/on-pr.yml b/.github/workflows/on-pr.yml
@@ -12,7 +12,11 @@ jobs:
   spdx:
     uses: ./.github/workflows/spdx.yml
     secrets: inherit
-  build-and-test:
+  build:
     needs: [pre-commit, spdx]
-    uses: ./.github/workflows/build-and-test.yml
+    uses: ./.github/workflows/run-build.yml
+    secrets: inherit
+  test:
+    needs: build
+    uses: ./.github/workflows/run-tests.yml
     secrets: inherit
diff --git a/.github/workflows/on-push.yml b/.github/workflows/on-push.yml
@@ -12,7 +12,11 @@ jobs:
   spdx:
     uses: ./.github/workflows/spdx.yml
     secrets: inherit
-  build-and-test:
+  build:
     needs: [pre-commit, spdx]
-    uses: ./.github/workflows/build-and-test.yml
+    uses: ./.github/workflows/run-build.yml
+    secrets: inherit
+  test:
+    needs: build
+    uses: ./.github/workflows/run-tests.yml
     secrets: inherit
diff --git a/.github/workflows/build-and-test.yml → .github/workflows/run-build.yml b/.github/workflows/build-and-test.yml → .github/workflows/run-build.yml
@@ -1,4 +1,4 @@
-name: Build and Test
+name: Build
 
 on:
   workflow_dispatch:
@@ -84,7 +84,7 @@ jobs:
 
   # # Run tests on TT hardware
 
-  build-and-run-tests:
+  build:
     timeout-minutes: 120
     strategy:
       fail-fast: false
@@ -121,6 +121,9 @@ jobs:
         echo "build-output-dir=$(pwd)/build" >> "$GITHUB_OUTPUT"
         echo "install-output-dir=$(pwd)/install" >> "$GITHUB_OUTPUT"
 
+    - name: Git safe dir
+      run: git config --global --add safe.directory ${{ steps.strings.outputs.work-dir }}
+
     - name: ccache
       uses: hendrikmuhs/[email protected]
       with:
@@ -134,6 +137,7 @@ jobs:
         source env/activate
         cmake -G Ninja \
         -DCMAKE_CXX_COMPILER_LAUNCHER=ccache \
+        -DCMAKE_INSTALL_PREFIX=${{ steps.strings.outputs.install-output-dir }} \
         -B ${{ steps.strings.outputs.build-output-dir }} \
         -S ${{ steps.strings.outputs.work-dir }}
 
@@ -144,16 +148,31 @@ jobs:
         cmake --build ${{ steps.strings.outputs.build-output-dir }}
         cmake --install ${{ steps.strings.outputs.build-output-dir }}
 
-    - name: Run PyTorch tests
+    - name: Copy tt-metal binaries
       shell: bash
+      working-directory: ${{ steps.strings.outputs.install-output-dir }}
       run: |
-        export LD_LIBRARY_PATH="/opt/ttmlir-toolchain/lib/:${{ steps.strings.outputs.install-output-dir }}/lib:${LD_LIBRARY_PATH}"
-        source env/activate
-        pytest -v tests/torch
+        cp ${{ steps.strings.outputs.work-dir }}/third_party/tt-mlir/src/tt-mlir/third_party/tt-metal/src/tt-metal-build/lib/*.so lib/
+        cp ${{ steps.strings.outputs.work-dir }}/third_party/tt-mlir/src/tt-mlir/third_party/tt-metal/src/tt-metal-build/_deps/fmt-build/*.so* lib/
+        cp ${{ steps.strings.outputs.work-dir }}/third_party/tt-mlir/src/tt-mlir/third_party/tt-metal/src/tt-metal-build/_deps/nanomsg-build/*.so* lib/
+        cp ${{ steps.strings.outputs.work-dir }}/third_party/tt-mlir/src/tt-mlir/third_party/tt-metal/src/tt-metal-build/_deps/libuv-build/*.so* lib/
 
-    - name: Run ONNX tests
+    - name: Copy tt-metal directories
       shell: bash
+      working-directory: ${{ steps.strings.outputs.install-output-dir }}
       run: |
-        export LD_LIBRARY_PATH="/opt/ttmlir-toolchain/lib/:${{ steps.strings.outputs.install-output-dir }}/lib:${LD_LIBRARY_PATH}"
-        source env/activate
-        pytest -v tests/onnx
+        mkdir tt-metal
+        cp -r ${{ steps.strings.outputs.work-dir }}/third_party/tt-mlir/src/tt-mlir/third_party/tt-metal/src/tt-metal/tt_metal tt-metal/
+        cp -r ${{ steps.strings.outputs.work-dir }}/third_party/tt-mlir/src/tt-mlir/third_party/tt-metal/src/tt-metal/ttnn tt-metal/
+        cp -r ${{ steps.strings.outputs.work-dir }}/third_party/tt-mlir/src/tt-mlir/third_party/tt-metal/src/tt-metal/runtime tt-metal/
+
+    - name: 'Tar install directory'
+      shell: bash
+      working-directory: ${{ steps.strings.outputs.install-output-dir }}
+      run: tar cvf artifact.tar .
+
+    - name: Upload install folder to archive
+      uses: actions/upload-artifact@v4
+      with:
+        name: install-artifacts
+        path: ${{ steps.strings.outputs.install-output-dir }}/artifact.tar
diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
@@ -0,0 +1,85 @@
+name: Run Tests
+
+on:
+  workflow_dispatch:
+  workflow_call:
+  workflow_run:
+    workflows: [Build]
+    types: [completed]
+
+jobs:
+  tests:
+    timeout-minutes: 120
+    strategy:
+      fail-fast: false
+      matrix:
+        build: [
+          {runs-on: n150, name: "run"},
+        ]
+
+    runs-on:
+      - in-service
+      - ${{ matrix.build.runs-on }}
+
+    container:
+      image: ghcr.io/tenstorrent/tt-torch/tt-torch-ci-ubuntu-22-04:latest
+      options: --user root --device /dev/tenstorrent/0
+      volumes:
+        - /dev/hugepages:/dev/hugepages
+        - /dev/hugepages-1G:/dev/hugepages-1G
+        - /etc/udev/rules.d:/etc/udev/rules.d
+        - /lib/modules:/lib/modules
+        - /opt/tt_metal_infra/provisioning/provisioning_env:/opt/tt_metal_infra/provisioning/provisioning_env
+
+    steps:
+    - uses: actions/checkout@v4
+      with:
+        submodules: recursive
+        lfs: true
+
+    - name: Set reusable strings
+      id: strings
+      shell: bash
+      run: |
+        echo "work-dir=$(pwd)" >> "$GITHUB_OUTPUT"
+        echo "build-output-dir=$(pwd)/build" >> "$GITHUB_OUTPUT"
+        echo "install-output-dir=$(pwd)/install" >> "$GITHUB_OUTPUT"
+
+    - name: Git safe dir
+      run: git config --global --add safe.directory ${{ steps.strings.outputs.work-dir }}
+
+    - name: Use build artifacts
+      uses: actions/download-artifact@v4
+      with:
+        name: install-artifacts
+        path: ${{ steps.strings.outputs.install-output-dir }}
+
+    - name: 'Untar install directory'
+      shell: bash
+      working-directory: ${{ steps.strings.outputs.install-output-dir }}
+      run: tar xvf artifact.tar
+
+    - name: make tt-metal directory
+      shell: bash
+      working-directory: ${{ steps.strings.outputs.install-output-dir }}
+      run: mkdir -p ${{ steps.strings.outputs.work-dir }}/third_party/tt-mlir/src/tt-mlir/third_party/tt-metal/src/tt-metal
+
+    - name: copy tt-metal dirs
+      shell: bash
+      working-directory: ${{ steps.strings.outputs.install-output-dir }}
+      run: |
+        cp -r ${{ steps.strings.outputs.install-output-dir }}/tt-metal/* ${{ steps.strings.outputs.work-dir }}/third_party/tt-mlir/src/tt-mlir/third_party/tt-metal/src/tt-metal
+
+    - name: Run PyTorch tests
+      shell: bash
+      run: |
+        source env/activate
+        export LD_LIBRARY_PATH="/opt/ttmlir-toolchain/lib/:${{ steps.strings.outputs.install-output-dir }}/lib:${{ steps.strings.outputs.build-output-dir }}/lib:./lib/:${LD_LIBRARY_PATH}"
+        pytest -v tests/torch
+
+    - name: Run ONNX tests
+      shell: bash
+      run: |
+        source env/activate
+        export LD_LIBRARY_PATH="/opt/ttmlir-toolchain/lib/:${{ steps.strings.outputs.install-output-dir }}/lib:${{ steps.strings.outputs.build-output-dir }}/lib:./lib/:${LD_LIBRARY_PATH}"
+        pytest -v tests/onnx